Skip to content

Commit

Permalink
Remove some more cppcheck warnings.
Browse files Browse the repository at this point in the history
This patch removes some more simple cppcheck warnings and updates two of
the cppcheck suppression files.
  • Loading branch information
caryr authored and steveicarus committed Jan 13, 2011
1 parent a2a7c9b commit 20f3d7c
Show file tree
Hide file tree
Showing 6 changed files with 17 additions and 17 deletions.
4 changes: 2 additions & 2 deletions cppcheck.sup
@@ -1,3 +1,3 @@
// These are correct and are used to find the base (zero) pin. // These are correct and are used to find the base (zero) pin.
thisSubtraction:netlist.h:4119 thisSubtraction:netlist.h:4165
thisSubtraction:netlist.h:4128 thisSubtraction:netlist.h:4174
4 changes: 2 additions & 2 deletions design_dump.cc
@@ -1,5 +1,5 @@
/* /*
* Copyright (c) 1998-2010 Stephen Williams (steve@icarus.com) * Copyright (c) 1998-2011 Stephen Williams (steve@icarus.com)
* *
* This source code is free software; you can redistribute it * This source code is free software; you can redistribute it
* and/or modify it in source code form under the terms of the GNU * and/or modify it in source code form under the terms of the GNU
Expand Down Expand Up @@ -1217,7 +1217,7 @@ void NetScope::dump(ostream&o) const


// Dump the signals, // Dump the signals,
for (signals_map_iter_t cur = signals_map_.begin() for (signals_map_iter_t cur = signals_map_.begin()
; cur != signals_map_.end() ; cur ++) { ; cur != signals_map_.end() ; ++ cur) {
cur->second->dump_net(o, 4); cur->second->dump_net(o, 4);
} }


Expand Down
4 changes: 2 additions & 2 deletions emit.cc
@@ -1,5 +1,5 @@
/* /*
* Copyright (c) 1998-2010 Stephen Williams (steve@icarus.com) * Copyright (c) 1998-2011 Stephen Williams (steve@icarus.com)
* *
* This source code is free software; you can redistribute it * This source code is free software; you can redistribute it
* and/or modify it in source code form under the terms of the GNU * and/or modify it in source code form under the terms of the GNU
Expand Down Expand Up @@ -404,7 +404,7 @@ void NetScope::emit_scope(struct target_t*tgt) const
// in the list. We can do it here because delay paths are // in the list. We can do it here because delay paths are
// always connected within the scope. // always connected within the scope.
for (signals_map_iter_t cur = signals_map_.begin() for (signals_map_iter_t cur = signals_map_.begin()
; cur != signals_map_.end() ; cur ++) { ; cur != signals_map_.end() ; ++ cur) {


tgt->signal_paths(cur->second); tgt->signal_paths(cur->second);
} }
Expand Down
4 changes: 2 additions & 2 deletions functor.cc
@@ -1,5 +1,5 @@
/* /*
* Copyright (c) 1999-2010 Stephen Williams (steve@icarus.com) * Copyright (c) 1999-2011 Stephen Williams (steve@icarus.com)
* *
* This source code is free software; you can redistribute it * This source code is free software; you can redistribute it
* and/or modify it in source code form under the terms of the GNU * and/or modify it in source code form under the terms of the GNU
Expand Down Expand Up @@ -115,7 +115,7 @@ void NetScope::run_functor(Design*des, functor_t*fun)
signals_map_iter_t cur = signals_map_.begin(); signals_map_iter_t cur = signals_map_.begin();
while (cur != signals_map_.end()) { while (cur != signals_map_.end()) {
signals_map_iter_t tmp = cur; signals_map_iter_t tmp = cur;
cur ++; ++ cur;
fun->signal(des, tmp->second); fun->signal(des, tmp->second);
} }
} }
Expand Down
4 changes: 2 additions & 2 deletions net_design.cc
@@ -1,5 +1,5 @@
/* /*
* Copyright (c) 2000-2010 Stephen Williams (steve@icarus.com) * Copyright (c) 2000-2011 Stephen Williams (steve@icarus.com)
* *
* This source code is free software; you can redistribute it * This source code is free software; you can redistribute it
* and/or modify it in source code form under the terms of the GNU * and/or modify it in source code form under the terms of the GNU
Expand Down Expand Up @@ -678,7 +678,7 @@ void NetScope::evaluate_parameters(Design*des)


is_param_expr = true; is_param_expr = true;
for (param_ref_t cur = parameters.begin() for (param_ref_t cur = parameters.begin()
; cur != parameters.end() ; cur ++) { ; cur != parameters.end() ; ++ cur) {


evaluate_parameter_(des, cur); evaluate_parameter_(des, cur);
} }
Expand Down
14 changes: 7 additions & 7 deletions vpi/cppcheck.sup
Expand Up @@ -3,14 +3,14 @@
// problems will not be fixed. // problems will not be fixed.


// fstapi.c from GTKWave // fstapi.c from GTKWave
variableScope:fstapi.c:1497
variableScope:fstapi.c:1614 variableScope:fstapi.c:1614
variableScope:fstapi.c:1663 variableScope:fstapi.c:1731
variableScope:fstapi.c:1664 variableScope:fstapi.c:1780
variableScope:fstapi.c:2355 variableScope:fstapi.c:1781
variableScope:fstapi.c:2670 variableScope:fstapi.c:2472
variableScope:fstapi.c:2674 variableScope:fstapi.c:2787
variableScope:fstapi.c:2675 variableScope:fstapi.c:2791
variableScope:fstapi.c:2792


// lxt2_write.c from GTKWave // lxt2_write.c from GTKWave
variableScope:lxt2_write.c:63 variableScope:lxt2_write.c:63
Expand Down

0 comments on commit 20f3d7c

Please sign in to comment.