allow multiple paths per script #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems to work for me. A test would be cool tho. |
|
This pull request a duplicate of #17, albeit that it doesn't overload the @nickhammond: It would be great if one of these requests was merged :). |
|
Planning on merging in this one, just need to add a test for it as @otakup0pe mentioned. |
This was referenced Feb 8, 2018
Closed
ryanpineo
force-pushed
the
multiple-paths
branch
from
34b772d
to
2075b4a
Compare
ryanpineo
force-pushed
the
multiple-paths
branch
from
2075b4a
to
9255086
Compare
|
@nickhammond I tried adding a test, let me know if it's good |
|
@ryanpineo this looks great, I'll get this merged in this weekend and then bump the version. Thanks for keeping backwards compatibility as well! |
Closed
|
Merged and tagged as v0.0.5, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added a new
pathsvariable that can be used in each script instead ofpathto allow people to specify multiple paths in 1 script without breaking backwards compatibility.