Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenFiles call crashes on RHEL6.5 #15

Closed
nickjones opened this issue Dec 1, 2015 · 1 comment
Closed

OpenFiles call crashes on RHEL6.5 #15

nickjones opened this issue Dec 1, 2015 · 1 comment
Labels
bug

Comments

@nickjones
Copy link
Owner

Trying to collect open files statistics on RHEL6.5 crashes the entire Go stack:

github.com/shirou/gopsutil/process.(*Process).OpenFiles(0xc82012e090, 0x0, 0x0, 0x0, 0x0, 0x0)
    .../go/src/github.com/shirou/gopsutil/process/process_linux.go:228 +0x1f6
@nickjones nickjones added the bug label Dec 1, 2015
nickjones added a commit that referenced this issue Dec 7, 2015
@nickjones
Issue #15 Recover from stat collection panics
1164f79 
Some platforms (RHEL6/CentOS 6) will runtime panic collecting the
OpenFiles statistic.  Potentially any one of these sources could
generate a panic; however, there's no reason to crash the entire stack
(including the important monitored process) if we can't collect some bit
of statistics.  Each call into gopsutil is now protected to enable
collecting as much as possible each cycle.
@nickjones
Copy link
Owner Author

Not really "fixed" but recovery on possible panics from collecting statistics should have been in place anyway to protect the underlying boxed process. Calling this closed for now unless someone really cares about collecting OpenFiles stats on RHEL6/CentOS6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nickjones