fix indices out-of-bounds from issues 10 #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this tested on any other open data set that you could share? I'd like to address this problem and merge your PR after verifying the fix. Thanks! |
nickkunz
reviewed
Mar 14, 2024
| @@ -46,7 +46,7 @@ def heom_dist(a_num, b_num, d_num, ranges_num, a_nom, b_nom, d_nom): | |||
| # import numpy as np | |||
|
|
|||
| ## create list to store distances | |||
| dist = [None] * d_num | |||
| dist = [None] * (d_num + d_nom) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think dist variable should have length of d_num + d_nom because the heom distance function have loop of both d_num and d_nom, previously loop through d_num only will produce error when d_nom length is larger than d_num which resulted in index out of bound. My fix is not pretty, but it works on housing dataset from issues 10.