Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HOTFIX: EventSub pagination #112

Merged
merged 1 commit into from
Jul 26, 2021
Merged

HOTFIX: EventSub pagination #112

merged 1 commit into from
Jul 26, 2021

Conversation

jackmcguire1
Copy link
Contributor

@jackmcguire1 jackmcguire1 commented Jul 26, 2021 •
edited
Loading

  • add 'after' field to EventSubSubscriptionsParams struct
  • add 'type' field to enable the ability to filter eventsubs by type i.e. 'channel.follow'

@jackmcguire1
EventSub pagination
0c4e5e1 
- add pagination to eventsub
HOTFIX: 'omitempty'

- stop using omitempty query tag value
   i think it messes it up :(
@coveralls
Copy link

coveralls commented Jul 26, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1068165178

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 96.602%
Totals Coverage Status
Change from base Build 1057421189: 0.2%
Covered Lines: 1052
Relevant Lines: 1089
💛 - Coveralls

This was referenced Jul 26, 2021
Closed
Closed
@nicklaw5 nicklaw5 merged commit 343474f into nicklaw5:main Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicklaw5 nicklaw5 nicklaw5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jackmcguire1 @coveralls @nicklaw5