Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add client.CreateStreamMarker(params) #17

Merged
merged 3 commits into from
Nov 30, 2018
Merged

Add client.CreateStreamMarker(params) #17

merged 3 commits into from
Nov 30, 2018

Conversation

flipkick
Copy link
Contributor

The "Create Stream Marker" API Endpoint.

@coveralls
Copy link

coveralls commented Nov 30, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 101

  • 12 of 14 (85.71%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 91.228%
Changes Missing Coverage Covered Lines Changed/Added Lines %
stream_markers.go 12 14 85.71%
Totals Coverage Status
Change from base Build 97: -0.1%
Covered Lines: 572
Relevant Lines: 627
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 99

  • 17 of 19 (89.47%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.06%) to 91.297%
Changes Missing Coverage Covered Lines Changed/Added Lines %
stream_markers.go 17 19 89.47%
Totals Coverage Status
Change from base Build 97: -0.06%
Covered Lines: 577
Relevant Lines: 632
💛 - Coveralls

nicklaw5
nicklaw5 requested changes Nov 30, 2018
View reviewed changes
Copy link
Owner

@nicklaw5 nicklaw5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Just the one thing that I'd like to see changed (see comments).

stream_markers.go Outdated Show resolved Hide resolved
docs/stream_markers_docs.md Outdated Show resolved Hide resolved
stream_markers_test.go Outdated Show resolved Hide resolved
@flipkick
Copy link
Contributor Author

Yes, sure. I didn't see that the description is optional.

@flipkick flipkick changed the title Add client.CreateStreamMarker(user_id, description) Add client.CreateStreamMarker(params) Nov 30, 2018
@nicklaw5 nicklaw5 merged commit a408f7c into nicklaw5:master Nov 30, 2018
@nicklaw5
Copy link
Owner

Thanks again. It's super nice of you to contribute 😃

@nicklaw5 nicklaw5 mentioned this pull request Nov 30, 2018
Closed
@flipkick flipkick deleted the stream_markers branch November 30, 2018 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicklaw5 nicklaw5 nicklaw5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@flipkick @coveralls @nicklaw5