Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: AddBlockedTerm struct field tags and request issues #209

Merged
merged 2 commits into from
Jan 9, 2024
Merged

fix: AddBlockedTerm struct field tags and request issues #209

merged 2 commits into from
Jan 9, 2024

Conversation

jackmcguire1
Copy link
Contributor

@jackmcguire1 jackmcguire1 commented Jan 3, 2024 •
edited
Loading

  • use postAsJson function
  • moderator_id, broadcaster_id, after, first are request query parameters
  • fix AddBlockedTermParams, BlockedTermsParams

#208

@jackmcguire1
fix: add block term request
7102c68 
- use postAsJson function
- moderator and broadcasterIDs are query parameters
@jackmcguire1 jackmcguire1 mentioned this pull request Jan 3, 2024
Closed
@coveralls
Copy link

coveralls commented Jan 3, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7399503974

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.517%
Totals Coverage Status
Change from base Build 6590572596: 0.0%
Covered Lines: 1669
Relevant Lines: 1804
💛 - Coveralls

@jackmcguire1 jackmcguire1 changed the title fix: add block term request fix: add block term request not using postAsJson and query parameters for broadcaster/moderator IDs Jan 3, 2024
@jackmcguire1 jackmcguire1 mentioned this pull request Jan 3, 2024
Closed
@jackmcguire1 jackmcguire1 changed the title fix: add block term request not using postAsJson and query parameters for broadcaster/moderator IDs fix: AddBlockedTerm struct field tags and request issues Jan 6, 2024
@nicklaw5 nicklaw5 merged commit 7714798 into nicklaw5:main Jan 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicklaw5 nicklaw5 nicklaw5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jackmcguire1 @coveralls @nicklaw5