Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename callApi to getApi #92

Closed
Brandin opened this issue Dec 11, 2020 · 0 comments
Closed

Rename callApi to getApi #92

Brandin opened this issue Dec 11, 2020 · 0 comments

Comments

@Brandin
Copy link
Collaborator

Brandin commented Dec 11, 2020

With put, post, and delete being the other methods, we should really name this one get. Not now, of course. That will be a breaking change. We can do it for the next major release. Please ticket? :-)

Originally posted by @echosa in #91 (comment)
@Brandin Brandin mentioned this issue Dec 11, 2020
Merged
Brandin added a commit to Brandin/twitch-api-php that referenced this issue Dec 11, 2020
@Brandin
Rename callApi to getApi nicklaw5#92
42865af
@Brandin Brandin mentioned this issue Dec 11, 2020
Merged
Brandin added a commit to Brandin/twitch-api-php that referenced this issue Feb 25, 2021
@Brandin
Rename callApi to getApi nicklaw5#92
be31fe7
@Brandin Brandin closed this as completed Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Brandin