Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Swift Package Manager #238

Closed
wants to merge 1 commit into from

Conversation

LinusU
Copy link

@LinusU LinusU commented Mar 28, 2018

Benefits:

Left to do:

  • Figure out why there wasn't an import SwiftFormat in CommandLineTool/main.swift before 🤔 will adding it break anything?
  • Maybe update the readme with build and Mint instructions?

What works:

  • Building: swift build -Xswiftc -target -Xswiftc x86_64-apple-macosx10.11
  • Running tests: swift test -Xswiftc -target -Xswiftc x86_64-apple-macosx10.11

Notes:

All tests passed locally:

Test Suite 'CommandLineTests' passed at 2018-03-28 15:07:51.344.
	 Executed 21 tests, with 0 failures (0 unexpected) in 0.270 (0.271) seconds
Test Suite 'FormatterTests' passed at 2018-03-28 15:07:51.367.
	 Executed 6 tests, with 0 failures (0 unexpected) in 0.023 (0.023) seconds
Test Suite 'OptionsTests' passed at 2018-03-28 15:07:51.422.
	 Executed 52 tests, with 0 failures (0 unexpected) in 0.052 (0.055) seconds
Test Suite 'PerformanceTests' passed at 2018-03-28 15:23:35.086.
	 Executed 10 tests, with 0 failures (0 unexpected) in 943.663 (943.663) seconds
Test Suite 'RulesTests' passed at 2018-03-28 15:23:38.563.
	 Executed 778 tests, with 0 failures (0 unexpected) in 3.381 (3.477) seconds
Test Suite 'SwiftFormatTests' passed at 2018-03-28 15:23:38.592.
	 Executed 12 tests, with 0 failures (0 unexpected) in 0.027 (0.028) seconds
Test Suite 'TokenizerTests' passed at 2018-03-28 15:23:38.683.
	 Executed 200 tests, with 0 failures (0 unexpected) in 0.079 (0.091) seconds
Test Suite 'SwiftFormatPackageTests.xctest' passed at 2018-03-28 15:23:38.683.
	 Executed 1079 tests, with 0 failures (0 unexpected) in 947.494 (947.611) seconds
Test Suite 'All tests' passed at 2018-03-28 15:23:38.684.
	 Executed 1079 tests, with 0 failures (0 unexpected) in 947.494 (947.612) seconds

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.002%) to 83.802% when pulling 4612ba3 on LinusU:swiftpm into a00d6fc on nicklockwood:master.

@yonaskolb
Copy link
Contributor

Duplicate of #183

@LinusU
Copy link
Author

LinusU commented Apr 10, 2018

Haha 🤦‍♂️, seems like I was a bit eager here...

@LinusU LinusU closed this Apr 10, 2018
@yonaskolb
Copy link
Contributor

No, it's good. I've love for one of these to get merged

@LinusU
Copy link
Author

LinusU commented Apr 10, 2018

Yeah, me too! Ping @nicklockwood

@yonaskolb
Copy link
Contributor

I think this is actually more up to date 👍
@LinusU you should open it again

@yonaskolb
Copy link
Contributor

Actually just updated my branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants