Add extension support to organizeDeclarations #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calda
commented
Sep 19, 2020
| `--structthreshold` | Minimum line count to organize struct body. Defaults to 0 | ||
| `--classthreshold` | Minimum line count to organize class body. Defaults to 0 | ||
| `--enumthreshold` | Minimum line count to organize enum body. Defaults to 0 | ||
| `--extensionlength` | Minimum line count to organize extension body. Defaults to 0 |
There was a problem hiding this comment.
I would have preferred to call this --extensionthreshold to match the other existing options, but that was two characters over the 16 character limit.
nicklockwood
force-pushed
the
develop
branch
4 times, most recently
from
c9b7f47
to
dffcfec
Compare
calda
force-pushed
the
cal--organizeDeclarations-extension
branch
from
b5fa5fc
to
16562f1
Compare
nicklockwood
force-pushed
the
develop
branch
5 times, most recently
from
af1d162
to
663bd59
Compare
nicklockwood
force-pushed
the
develop
branch
4 times, most recently
from
5cff77e
to
aed132e
Compare
calda
force-pushed
the
cal--organizeDeclarations-extension
branch
from
a9e3d64
to
7c37eb5
Compare
|
@nicklockwood I rebased this PR off of the latest changes to |
nicklockwood
pushed a commit
that referenced
this pull request
Sep 27, 2020
nicklockwood
pushed a commit
that referenced
this pull request
Sep 27, 2020
nicklockwood
pushed a commit
that referenced
this pull request
Sep 29, 2020
nicklockwood
pushed a commit
that referenced
this pull request
Oct 13, 2020
nicklockwood
pushed a commit
that referenced
this pull request
Oct 13, 2020
Lukasz2891
pushed a commit
to Lukasz2891/SwiftFormat
that referenced
this pull request
Oct 23, 2020
leogdion
pushed a commit
to brightdigit/SwiftFormatSlim
that referenced
this pull request
Nov 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds support for organizing the body of
extensiondeclarations withorganizeDeclarations.This is optional, since you'd probably only want to do this if you're using the
extensionAccessControlrule (#742), and configurable using the new--organizetypesoption.