Merge pull request Quick#944 from pobengtsson/add-empty-default-flags…

…-to-xdescribe-xcontext Added empty default flags to xdescribe and xcontext
nickm01 · Feb 12, 2020 · 1e66350 · 1e66350
2 parents f26a21e + ef507c7
commit 1e66350
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/Sources/Quick/DSL/DSL.swift b/Sources/Quick/DSL/DSL.swift
@@ -198,15 +198,15 @@ public func pending(_ description: String, closure: () -> Void) {
     Use this to quickly mark a `describe` closure as pending.
     This disables all examples within the closure.
 */
-public func xdescribe(_ description: String, flags: FilterFlags, closure: () -> Void) {
+public func xdescribe(_ description: String, flags: FilterFlags = [:], closure: () -> Void) {
     World.sharedWorld.xdescribe(description, flags: flags, closure: closure)
 }
 
 /**
     Use this to quickly mark a `context` closure as pending.
     This disables all examples within the closure.
 */
-public func xcontext(_ description: String, flags: FilterFlags, closure: () -> Void) {
+public func xcontext(_ description: String, flags: FilterFlags = [:], closure: () -> Void) {
     xdescribe(description, flags: flags, closure: closure)
 }
 

diff --git a/Tests/QuickTests/QuickTests/FunctionalTests/PendingTests.swift b/Tests/QuickTests/QuickTests/FunctionalTests/PendingTests.swift
@@ -28,6 +28,18 @@ class FunctionalTests_PendingSpec: QuickSpec {
             beforeEach { onlyPendingExamplesBeforeEachExecutedCount += 1 }
             pending("an example that will not run") {}
         }
+        describe("a describe block with a disabled context that will not run") {
+            xcontext("these examples will not run") {
+               it("does not run") {
+                  fail()
+               }
+            }
+        }
+        xdescribe("a describe block that will not run") {
+            it("does not run") {
+               fail()
+            }
+        }
     }
 }