Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update examples to include Jest #183

Merged
merged 2 commits into from May 1, 2018

Conversation

Ethan-Arrowood
Copy link
Contributor

Also included link to my project where I am successfully implementing jest coverage and travis-ci

Also included link to my project where I am successfully implementing jest coverage and travis-ci
@coveralls
Copy link

coveralls commented Jan 14, 2018

Coverage Status

Coverage remained the same at 95.77% when pulling abab772 on Ethan-Arrowood:patch-1 into 83ff2cb on nickmerwin:master.

@swenyang
Copy link

@Ethan-Arrowood thanks your script saved my life

README.md Outdated
- Install [jest](https://facebook.github.io/jest/docs/en/getting-started.html)
- Use the following to run tests and push files to coveralls:
```
jest --coverage && cat ./coverage/lcov.info | ./node_modules/coveralls/bin/coveralls.js && rm -rf ./coverage

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to just add coverage/ to the .gitignore instead of removing the whole directory.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll have to review my use case for this but I don't think adding coverage to my gitignore does the same thing.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. I figure Jest writes it there for some caching and optimization. It also allows you to check it again at a later time without re-running all the test. Small stuff, no worries.

README.md Outdated
- Install [jest](https://facebook.github.io/jest/docs/en/getting-started.html)
- Use the following to run tests and push files to coveralls:
```
jest --coverage && cat ./coverage/lcov.info | ./node_modules/coveralls/bin/coveralls.js && rm -rf ./coverage
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, but why not

jest --coverage --coverageReporters=text-lcov | coveralls

?

@panmona
Copy link

panmona commented Feb 24, 2018

Hmm I unfortunately can't get this to work.

No tests found

But I have tests and Travis executes them.

@thevtm
Copy link

thevtm commented Mar 9, 2018

I've been using @Yeti-or version and it works perfectly.

@nickmerwin nickmerwin merged commit 10d8b3e into nickmerwin:master May 1, 2018
@nickmerwin
Copy link
Owner

Thank you @Ethan-Arrowood and @Yeti-or!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants