Refactoring getOptions

[mattjmorrison]

Here is an example of something that I think would work for the grunt-karma-coveralls plugin for issue #22.

[coveralls]

Coverage increased (+0.17%) when pulling 3ab2c57 on mattjmorrison:master into 167119f on cainus:master.

[cainus]

Yep that's fine (theoretically). I suspect that the way you did the export won't get you the result that you're looking for though (You're not actually exporting getBaseOptions()). If you add a simple test that uses getBaseOptions() directly, you'll see what I mean (we should probably have a test on that anyway, since this is a coverage tool.).

[coveralls]

Coverage increased (+0.17%) when pulling 8078aa0 on mattjmorrison:master into 167119f on cainus:master.

[mattjmorrison]

Good call on the exports, I totally added that as an after thought. I refactored the tests so the same tests will hit both getOptions and getBaseOptions and I also updated index.js so that getOptions should behave the same as it did before.

[cainus]

Ha very nice... I'm re-running that one build and expect it to pass. Sometimes coveralls.io gets flakey when I hit it with multiple coverage reports at once.

One question though: Don't you want index.js to export getBaseOptions?

[mattjmorrison]

If you would like, I can add getBaseOptions to index.js. I was planning on just doing something like this

var getBaseOptions = require('../lib/getOptions').getBaseOptions;

Adding it to index.js would probably be cleaner. I will go ahead and add that and update the tests to reflect that change.

[coveralls]

Coverage increased (+0.17%) when pulling 2d4e059 on mattjmorrison:master into 167119f on cainus:master.

[mattjmorrison]

Thanks. Do you know when you are going to publish a new version of node-coveralls to npm?

[cainus]

Just did! It's 2.3.0. Great work! Thanks for the help. Let me know if you need anything else.

[mattjmorrison]

@cainus did you publish to npm? The latest version that I see out there is 2.2.0.

[cainus]

Bah sorry... guess I skipped that step... just did it though.