Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable support for node16 #15

Merged
merged 9 commits into from
Sep 5, 2023
Merged

Conversation

wdconinc
Copy link
Contributor

@wdconinc wdconinc commented Sep 3, 2023

This upgrades this action (and actions used in ci) to node16, applies npm audit fixes, and removes all but the unexpected input warnings by switching away from set-output.

New check_dist check is from https://github.com/actions/typescript-action/blob/main/.github/workflows/check-dist.yml, also MIT licensed.

Copy link
Owner

@nickofthyme nickofthyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thank you so much.

I'll run the checks and merge ASAP.

FYI I'll tag it under v2 to avoid any breaking changes on v1.

.github/workflows/check-dist.yml Show resolved Hide resolved
clean_dist.sh Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
@nickofthyme nickofthyme merged commit 0bfa2be into nickofthyme:master Sep 5, 2023
4 checks passed
@wdconinc
Copy link
Contributor Author

wdconinc commented Sep 6, 2023

Tagging as v2 is indeed what I would have done too. I noticed that you tagged v2.0.0 but not the v2 (actions doesn't automatically interpret semantic versioning but requires those tags to be explicitly created, like the v1 tag).

@nickofthyme
Copy link
Owner

nickofthyme commented Sep 6, 2023

Yeah, back when I started this action GitHub suggested here to use v2 to bind the latest stable major version. This doc also has not been updated in 2 years.

But after looking at a few popular actions, including some from GitHub like octokit/request-action, I noticed they stopped doing the v2 tagging. Maybe they favor using v2.x instead. But I don't see any issues mentioning this naming change.

That said I'm happy to add the v2 tag if you'd like. Let me know.

@wdconinc
Copy link
Contributor Author

wdconinc commented Sep 6, 2023

octokit/request-action has a release series branch v2.x instead of an ever-changing tag. I think having a similar approach here would be useful too. It avoids having to use main and potentially ending up with incompatibilities. In any case, it's your call what you wish to do, of course.

@nickofthyme
Copy link
Owner

Oh I see, I wondered how they resolved the v2.x, the branch makes sense. I'll just add the v2 tag since I don't imagine a ton of future releases. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants