-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable support for node16 #15
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Thank you so much.
I'll run the checks and merge ASAP.
FYI I'll tag it under v2
to avoid any breaking changes on v1
.
Tagging as v2 is indeed what I would have done too. I noticed that you tagged v2.0.0 but not the v2 (actions doesn't automatically interpret semantic versioning but requires those tags to be explicitly created, like the v1 tag). |
Yeah, back when I started this action GitHub suggested here to use But after looking at a few popular actions, including some from GitHub like That said I'm happy to add the |
|
Oh I see, I wondered how they resolved the |
This upgrades this action (and actions used in ci) to node16, applies npm audit fixes, and removes all but the unexpected input warnings by switching away from set-output.
New check_dist check is from https://github.com/actions/typescript-action/blob/main/.github/workflows/check-dist.yml, also MIT licensed.