Skip to content
This repository has been archived by the owner on Feb 27, 2019. It is now read-only.

localization for UIAlertController possible? #104

Closed
TomMajor opened this issue Oct 10, 2015 · 6 comments
Closed

localization for UIAlertController possible? #104

TomMajor opened this issue Oct 10, 2015 · 6 comments

Comments

@TomMajor
Copy link

I am using localized strings like here:
#12 (comment)

Would it be possible to add this method also for the showDeniedAlert function? Otherwise the localization is somewhat broken, because of a mixed language if using this framework on a non-English system.

I would need these strings here:

"Permission for (permission) was denied."
"Please enable access to (permission) in the Settings app"
"OK"
"Show me"

Well, actually "OK" is fine without translation :)
Not sure how the method you already have (e.g. "Allow Camera" = "";) would work with this:
(permission)
I could of course patch this for myself locally, but then with each update I would loose the patch.

Thanks,
Tom

@bre7
Copy link
Collaborator

bre7 commented Oct 10, 2015

Those strings were already localized by Leshich in #103 which I've just merged. README needs an update about all the keys.

Keys updated in #12 (comment)

@bre7 bre7 closed this as completed Oct 10, 2015
@TomMajor
Copy link
Author

Hello bre7,

wow, that was fast, thank you very much.

I am new to CocoaPods, I did a "pod update", also a "pod update
PermissionScope" in my project directory, but your/Leshich change from
today does not show in my project.

Do I miss something here? Sorry if this is a silly question. Asking
Google told me that pod update should be the right thing to do.

Thanks,
Tom

bre7 schrieb am 10.10.2015 um 23:51:

Those strings were already localized by Leshich in PR #103
#103 which I've just
merged. README needs an update about all the keys.


Reply to this email directly or view it on GitHub
#104 (comment).

@bre7
Copy link
Collaborator

bre7 commented Oct 10, 2015

Nope, you just need to wait for @nickoneill to push the new version to CP. You could also add this to your podfile:

pod 'PermissionScope', :head

Using :head instead of a fixed version will always check out the master branch from the repo.

@TomMajor
Copy link
Author

Thanks

bre7 schrieb am 11.10.2015 um 00:57:

Nope: You just need to wait for @nickoneill
https://github.com/nickoneill to push the new version to CP. You could
also add this to your podfile: pod 'PermissionScope', :head


Reply to this email directly or view it on GitHub
#104 (comment).

@nickoneill
Copy link
Owner

Use :head if it's important for you today. I'm going to review and test the new contacts framework PR and push a new version out to cocoapods tomorrow or Monday.

@TomMajor
Copy link
Author

Did a manual update. Localization is working great now, thank you.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants