Skip to content

Commit

Permalink
updated tests
Browse files Browse the repository at this point in the history
  • Loading branch information
nickp60 committed Sep 27, 2017
1 parent 7401aab commit e9d214c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions pyutilsnrw/utils3_5.py
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,7 @@ def check_version_from_cmd(
20170920 changed to remove shutil.which call.
That should be done outside of this funciton
"""
assert logger is not None, "must use logging"
from distutils.version import StrictVersion
result = subprocess.run("{0} {1}".format(exe, cmd),
# is this a securiy risk?
Expand Down
2 changes: 1 addition & 1 deletion tests/test_utils3_5.py
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ def test_cmd_version(self):
cmd=' --version',
line=1,
pattern=r"pip (?P<version>[^from]+)",
# logger=logger,
logger=logger,
where='stdout',
min_version="0.0.0")
self.assertTrue(pip_version > '7.0.0')
Expand Down

0 comments on commit e9d214c

Please sign in to comment.