Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up lintr continuous integration and fix lints #58

Merged
merged 15 commits into from
Apr 28, 2023
Merged

Set up lintr continuous integration and fix lints #58

merged 15 commits into from
Apr 28, 2023

Commits on Apr 25, 2023

  1. Run styler::style_pkg()

    @Bisaloo
    Bisaloo committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    1aeb338 View commit details
    Browse the repository at this point in the history

  2. Do not use vector boolean operators & or | in if 

    Since they can return a logical of length > 1 which will produce an error in if
Reported by lintr::vector_logic_linter()
    @Bisaloo
    Bisaloo committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    9c7b2a0 View commit details
    Browse the repository at this point in the history

  3. Use seq_along() and seq_len() rather than 1:x 

    To deal with the case when x is 0
Reported by lintr::seq_linter()
    @Bisaloo
    Bisaloo committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    df24443 View commit details
    Browse the repository at this point in the history

  4. Add leading 0 to doubles < 1 

    Recommended by lintr::numeric_leading_zero_linter()
    @Bisaloo
    Bisaloo committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    17e5478 View commit details
    Browse the repository at this point in the history

  5. Use TRUE/FALSE rather than T/F 

    Recommended by lintr::T_and_F_symbol_linter()
    @Bisaloo
    Bisaloo committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    14bce66 View commit details
    Browse the repository at this point in the history

  6. Use any() rather than sum() > 0 

    Recommended by lintr::boolean_arithmetic_linter()
    @Bisaloo
    Bisaloo committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    8bf4f04 View commit details
    Browse the repository at this point in the history

  7. Use log(c()) rather than c(log()) 

    For better performance because log() is vectorized
Recommended by lintr::inner_combiner_linter()
    @Bisaloo
    Bisaloo committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    8ed646c View commit details
    Browse the repository at this point in the history

  8. Remove unnecessary c() and replace %in% by == 

    Recommended by lintr::unnecessary_concatenation_linter()
    @Bisaloo
    Bisaloo committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    33bff36 View commit details
    Browse the repository at this point in the history

  9. Use paste0() rather than paste(sep = "") 

    Recommended by lintr::paste_linter()
    @Bisaloo
    Bisaloo committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    da0f822 View commit details
    Browse the repository at this point in the history

  10. Put { back on the same line as } 

    Recommended by lintr::brace_linter()
    @Bisaloo
    Bisaloo committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    43114ed View commit details
    Browse the repository at this point in the history

  11. Remove unused variables 

    Recommended by lintr::object_usage_linter()
    @Bisaloo
    Bisaloo committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    9521f25 View commit details
    Browse the repository at this point in the history

  12. Add lint-changed-files workflow

    @Bisaloo
    Bisaloo committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    67a73b8 View commit details
    Browse the repository at this point in the history

  13. Save .lintr configuration file

    @Bisaloo
    Bisaloo committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    745bb1c View commit details
    Browse the repository at this point in the history

  14. Fix R CMD check workflow

    @Bisaloo
    Bisaloo committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    81ed9a5 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2023

  1. Run devtools::document()

    @Bisaloo
    Bisaloo committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    ecd20cc View commit details
    Browse the repository at this point in the history