Add parsing of 2-winding transformers #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickrobinson251
commented
Sep 27, 2021
nickrobinson251
force-pushed
the
npr/transformers
branch
from
e0eceb6
to
ee14a64
Compare
- since data for each Transformer is spread over multiple lines, we can now have a line start with '0' and it not indicate the end of the section (since it in the middle of the data for a Transformer, not the start of a new record).
Codecov Report
@@ Coverage Diff @@
## main #11 +/- ##
==========================================
- Coverage 95.31% 95.07% -0.25%
==========================================
Files 2 2
Lines 128 142 +14
==========================================
+ Hits 122 135 +13
- Misses 6 7 +1
Continue to review full report at Codecov.
|
nickrobinson251
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to get us started with the transformers data (see #17 for details on the complexity)