Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Ember v4 Support, drop Ember < 3.24 #188

Merged
merged 6 commits into from Jan 14, 2022

Conversation

knownasilya
Copy link
Contributor

@knownasilya knownasilya commented Jan 13, 2022

Update addon to test against Ember v4, and drop support for Ember < 3.24.

Had to drop older versions due to ember-modiifer updates to support v4.

This resolves the following error:

Error: Invalid modifier manager compatibility specified
                at modifierCapabilities (http://localhost:7357/assets/vendor.js:37703:13)
                at http://localhost:7357/assets/vendor.js:61297:46
                at CustomModifierManager.getDelegateFor (http://localhost:7357/assets/vendor.js:37752:20)
                at CustomModifierManager.create (http://localhost:7357/assets/vendor.js:37768:27)
                at Object.evaluate (http://localhost:7357/assets/vendor.js:45058:25)
                at AppendOpcodes.evaluate (http://localhost:7357/assets/vendor.js:43638:19)
                at LowLevelVM.evaluateSyscall (http://localhost:7357/assets/vendor.js:47418:22)
                at LowLevelVM.evaluateInner (http://localhost:7357/assets/vendor.js:47374:14)
                at LowLevelVM.evaluateOuter (http://localhost:7357/assets/vendor.js:47366:14)
                at VM.next (http://localhost:7357/assets/vendor.js:48335:24)

@knownasilya knownasilya marked this pull request as ready for review January 13, 2022 20:10
@nickschot nickschot changed the title feat: Ember v4 Support feat: Ember v4 Support, drop Ember < 3.24 Jan 14, 2022
Copy link
Owner

@nickschot nickschot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! 🙏

@nickschot nickschot merged commit 640695d into nickschot:master Jan 14, 2022
@knownasilya knownasilya deleted the feat/ember-v4 branch January 14, 2022 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants