Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make fails due to failed tests/lack of tests #11

Closed
andrew-morris opened this issue Feb 16, 2020 · 2 comments
Closed

Make fails due to failed tests/lack of tests #11

andrew-morris opened this issue Feb 16, 2020 · 2 comments

Comments

@andrew-morris
Copy link

$ make
go test ./...
# github.com/nicksherron/bashhub-server/cmd
cmd/root.go:122:3: Println arg list ends with redundant newline
?       github.com/nicksherron/bashhub-server   [no test files]
make: *** [test] Error 2

The Println error can be fixed by merging the following PR: #10

New error from make after making this change is:

$ make
go test ./...
?       github.com/nicksherron/bashhub-server   [no test files]
?       github.com/nicksherron/bashhub-server/cmd       [no test files]
?       github.com/nicksherron/bashhub-server/internal  [no test files]
@andrew-morris
Copy link
Author

Would consider adding alternate functionality to enable the following workflow:

$ make
blah blah blah
$ make install

@nicksherron
Copy link
Owner

This has been fixed. The default command prints the help text and we also now have tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants