Fix panic caused by nil pointer dereference in "extract" command #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When walking the AST during extraction, if an identifier in a composite literal is encountered that does not define in that file, the `Obj` field of the `ast.Ident` will be nil. Rather than panicking in this case, have the literal string extraction function return false (no string found). Also, add a test case representing this scenario.
Codecov Report
@@ Coverage Diff @@
## master #211 +/- ##
==========================================
+ Coverage 82.85% 82.88% +0.02%
==========================================
Files 14 14
Lines 1301 1303 +2
==========================================
+ Hits 1078 1080 +2
Misses 159 159
Partials 64 64
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue described in #206 (more specifically, this comment).
In short, if an identifier is used inside a composite literal, e.g.
and that identifier (in this case,
SomeIdentifier) is defined in another file, the resultingast.Identwill have a nilObjfield, which is causing thegoi18n extractcommand to panic.This just adds a simple nil check before accessing the field to prevent the panic from happening.