Remove v2 directory #318
Merged
Remove v2 directory #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #318 +/- ##
=======================================
Coverage 82.81% 82.81%
=======================================
Files 15 15
Lines 1740 1740
=======================================
Hits 1441 1441
Misses 234 234
Partials 65 65 ☔ View full report in Codecov by Sentry. |
nicksnyder
force-pushed
the
remove-v2-directory
branch
from
17e4036
to
a87cb86
Compare
nicksnyder
force-pushed
the
remove-v2-directory
branch
from
a87cb86
to
a6ac4a3
Compare
Closed
|
It is not conform with semver and it is a big breaking change. |
|
Let's discuss in #319 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The v2 directory is an artifact of the fact that v1 and v2 co-existed in this repository for a while. v1 code was removed in #176. This moves all code that was in the v2 directory to the top level.