Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't panic if translation is empty #96

Merged
merged 3 commits into from
Apr 17, 2018
Merged

don't panic if translation is empty #96

merged 3 commits into from
Apr 17, 2018

Conversation

nicksnyder
Copy link
Owner

fixes #95

@codecov
Copy link

codecov bot commented Apr 17, 2018

Codecov Report

Merging #96 into master will increase coverage by 0.73%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #96      +/-   ##
==========================================
+ Coverage   63.13%   63.87%   +0.73%     
==========================================
  Files          27       27              
  Lines        2268     2270       +2     
==========================================
+ Hits         1432     1450      +18     
+ Misses        762      746      -16     
  Partials       74       74
Impacted Files Coverage Δ
v2/internal/message_template.go 61.53% <100%> (+61.53%) ⬆️
v2/i18n/localizer.go 79.76% <0%> (+2.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48de9c8...cf22f44. Read the comment docs.

@nicksnyder nicksnyder merged commit 8d5feca into master Apr 17, 2018
@nicksnyder nicksnyder deleted the emptytranslation branch April 17, 2018 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panic: Only a pointer to struct can be unmarshaled from TOML
1 participant