-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Windows #28
Comments
So I am working on a patch now, including ensuring first that existing tests are passing also on Windows |
I will work out at my pace a patch in this fork/branch https://github.com/pombredanne/honcho/tree/win_support and submit a pull request in due course when this is working fine and looking good |
I am mostly done fixing the code and tests for minimal Windows support, though the semantics of process management on Windows seem to be a tad puzzling at times.... |
This is now tracked in the #30 pull request |
@nickstenning : Hi Nick! I am trying to revive this: #6
You wrote then "If you can fix this (possibly by using signal and ignoring interrupts in the timer thread) I'll happily pull this in."
==> How would you do this?
Also alternatively and more simply on Windows, could we just kill the processes abruptly with no timer/no alarm?
That could be good enough to get only part of the code that cannot run on Windows to work i.e. here
honcho/honcho/process.py
Line 167 in 7f2cfa4
instead of this code:
we could use something along these lines:
What do you think?
let me try and test it in the meantime... as there are likely several other areas in the code and tests where some posix assumptions are made
The text was updated successfully, but these errors were encountered: