Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Windows #28

Closed
pombredanne opened this issue Feb 24, 2013 · 4 comments
Closed

Support Windows #28

pombredanne opened this issue Feb 24, 2013 · 4 comments

Comments

@pombredanne
Copy link
Contributor

@nickstenning : Hi Nick! I am trying to revive this: #6

You wrote then "If you can fix this (possibly by using signal and ignoring interrupts in the timer thread) I'll happily pull this in."
==> How would you do this?

Also alternatively and more simply on Windows, could we just kill the processes abruptly with no timer/no alarm?
That could be good enough to get only part of the code that cannot run on Windows to work i.e. here

signal.signal(signal.SIGALRM, kill)

instead of this code:

        signal.signal(signal.SIGALRM, kill)
        signal.alarm(5)

we could use something along these lines:

        if ON_POSIX:
            signal.signal(signal.SIGALRM, kill)
            signal.alarm(5)
        else:
            # SIGALRM is not supported on Windows: just kill instead
            kill(None, None)

What do you think?
let me try and test it in the meantime... as there are likely several other areas in the code and tests where some posix assumptions are made

@pombredanne
Copy link
Contributor Author

So I am working on a patch now, including ensuring first that existing tests are passing also on Windows

@pombredanne
Copy link
Contributor Author

I will work out at my pace a patch in this fork/branch https://github.com/pombredanne/honcho/tree/win_support and submit a pull request in due course when this is working fine and looking good

@pombredanne
Copy link
Contributor Author

I am mostly done fixing the code and tests for minimal Windows support, though the semantics of process management on Windows seem to be a tad puzzling at times....
I wonder if something like this wrapper: https://github.com/mozilla/mozbase/tree/master/mozprocess/mozprocess which is mostly tackling the Windows quirks might be needed too to get better stability
@nickstenning what do you think?

@pombredanne pombredanne mentioned this issue Mar 4, 2013
@pombredanne
Copy link
Contributor Author

This is now tracked in the #30 pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant