export: Default user name to app name #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and remove code for deducing current user. This makes the behavior consistent with Foreman (see nickstenning#109). Also, I think folks are more likely to want to run their apps as some app-specific user, not as the user running export. In fact, some folks may run `honcho export` on a completely different box than where they end up running the applications.
msabramo
force-pushed
the
export_default_user_to_app
branch
from
6232169
to
2d0caea
Compare
|
@nickstenning, @slafs: Whatcha think? |
|
Sure. +1 from me. In my deployments I also tend to stick with a username equal to my app name. |
|
@nickstenning: Wanna pull the trigger? |
|
LGTM. |
nickstenning
added a commit
that referenced
this pull request
Nov 29, 2014
export: Default user name to app name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and remove code for deducing current user.
This makes the behavior consistent with Foreman (see #109). Also, I think folks are more likely to want to run their apps as some app-specific user, not as the user running export. In fact, some folks may run
honcho exporton a completely different box than where they end up running the applications.