Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export: Display message about writing file #112

Conversation

msabramo
Copy link
Collaborator

This makes it consistent with Foreman (See #109) and is just nice for the user to know what is happening. Looks like this:

[marca@marca-mac2 export_test]$ honcho export supervisord .
[honcho export] writing: export_test.conf

[marca@marca-mac2 export_test]$ honcho export upstart .
[honcho export] writing: export_test-ansvc.conf
[honcho export] writing: export_test-ansvc-1.conf
[honcho export] writing: export_test.conf

@nickstenning
Copy link
Owner

This kind of output should go to sys.stderr I think.

@msabramo msabramo force-pushed the export_display_message_with_filename branch from e6f3956 to 263c340 Compare November 28, 2014 18:14
@msabramo
Copy link
Collaborator Author

This kind of output should go to sys.stderr I think.

Done.

@msabramo msabramo force-pushed the export_display_message_with_filename branch from 263c340 to fbcb550 Compare November 28, 2014 18:48
@nickstenning
Copy link
Owner

Ah, right, but I wouldn't use sys.stderr.write.

print(msg, file=sys.stderr)

This makes it consistent with Foreman (See nickstenning#109) and is just nice for
the user to know what is happening.
@msabramo msabramo force-pushed the export_display_message_with_filename branch from fbcb550 to 9e06206 Compare November 28, 2014 19:00
@msabramo
Copy link
Collaborator Author

Updated.

@msabramo
Copy link
Collaborator Author

msabramo commented Dec 1, 2014

@nickstenning, @slafs: How does this look?

@slafs
Copy link
Collaborator

slafs commented Dec 1, 2014

LGTM

@msabramo
Copy link
Collaborator Author

msabramo commented Dec 4, 2014

I should look at #119 before merging this

@nickstenning
Copy link
Owner

Added in 3d2b887.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants