Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add default value for arg --no-colour, --no-prefix #223

Merged
merged 1 commit into from Oct 30, 2021

Conversation

laobaox
Copy link
Contributor

@laobaox laobaox commented Jul 24, 2020

without default value for arg --no-prefix, you can not use:
honcho --no-prefix start
the --no-prefix dost not work, becase overide by sub command arg

you can only use:
honcho start --no-prefix

so, to add default value to support:
honcho --no-prefix --no-colour start

@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2020

Codecov Report

Merging #223 into master will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #223      +/-   ##
==========================================
+ Coverage   49.16%   49.24%   +0.08%     
==========================================
  Files          11       12       +1     
  Lines         598      599       +1     
  Branches       88       88              
==========================================
+ Hits          294      295       +1     
  Misses        293      293              
  Partials       11       11              
Impacted Files Coverage Δ
honcho/command.py 0.00% <ø> (ø)
honcho/__init__.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19c7890...0d40eb8. Read the comment docs.

@nickstenning
Copy link
Owner

Thank you for fixing this!

@nickstenning nickstenning merged commit ed3fdd2 into nickstenning:main Oct 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants