Drop Python 3.4 and add Python 3.7 #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickw444
approved these changes
Sep 7, 2019
| Flask LDAP3 Login uses the `ldap3 <http://ldap3.readthedocs.org/en/latest/>`_ library, maintaining compatability with | ||
| python 3.4 and backwards. | ||
| Flask LDAP3 Login uses the `ldap3 <http://ldap3.readthedocs.org/en/latest/>`_ library, | ||
| and maintains compatibility with those versions of Python supported by upstream. |
There was a problem hiding this comment.
I wonder if there is much value gained by continuing to support 2.7? It’d be interesting to see how many consumers are still using 2.7, considering its set to be sunset soon. I expect a great portion are apps in maintenance only mode without active development and probably could have the ldap dependency pinned to a pre 1.0 release.
There was a problem hiding this comment.
That's an interesting thought. I've created #71 to track that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the
.travis.ymlto build on newer Pythons.