Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure Tox for local tests #73

Merged
merged 2 commits into from Jan 18, 2020
Merged

Configure Tox for local tests #73

merged 2 commits into from Jan 18, 2020

Conversation

gmacon
Copy link
Collaborator

@gmacon gmacon commented Sep 24, 2019

I've had Tox set up locally so I can see what to expect when I open a PR. That seems useful enough to share, so here it is.

@coveralls
Copy link

coveralls commented Sep 24, 2019

Coverage Status

Coverage remained the same at 95.833% when pulling 440b64f on gmacon:tox into b6a26f3 on nickw444:master.

@gmacon
Copy link
Collaborator Author

gmacon commented Sep 27, 2019

Rebased onto master to resolve merge conflicts.

Copy link
Owner

@nickw444 nickw444 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Perhaps it would be worthwhile to be using tox in travis too to ensure consistency between local dev and PR tests?

tox.ini Outdated
@@ -0,0 +1,34 @@
[tox]
envlist = py27,py35,py36,py37,pypy,pypy3,lint,docs,coverage-combine
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not too familiar with tox, but my understanding is that we probably don't want 2.7 here?

Suggested change
envlist = py27,py35,py36,py37,pypy,pypy3,lint,docs,coverage-combine
envlist = py35,py36,py37,pypy,pypy3,lint,docs,coverage-combine

I think there is also a reference on L30, but might be my lack of familiarity with tox.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants