Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully remove loop argument #44

Merged
merged 1 commit into from Jul 16, 2022
Merged

Fully remove loop argument #44

merged 1 commit into from Jul 16, 2022

Conversation

nickw444
Copy link
Owner

@nickw444 nickw444 commented Jul 16, 2022

#43 partially removed passing loop to various asyncio functions/classes. This PR completes the change.

From the sounds of thing having a user-provided loop might now be unnecessary anyway, so removal of the constructor arg sounds like the trivial way forward:

https://stackoverflow.com/a/60315290

@nickw444 nickw444 merged commit 839d3e1 into master Jul 16, 2022
@nickw444 nickw444 deleted the nwhyte/remove-loop-arg branch July 18, 2022 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant