Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a favicon for the project #27

Closed
nickytonline opened this issue Oct 7, 2022 · 17 comments · Fixed by #32
Closed

Create a favicon for the project #27

nickytonline opened this issue Oct 7, 2022 · 17 comments · Fixed by #32
Assignees
Labels
design Anything related to visual design good first issue Good for newcomers

Comments

@nickytonline
Copy link
Owner

Is your feature request related to a problem? Please describe. A clear and
concise description of what the problem is. Ex. I'm always frustrated when [...]

SvelteKit ships with a default favicon.png located at static/favicon.png. It's currently the SvelteKit logo. There are no designs for this, but a favicon related to the game of Connect Four would be great to have. Maybe the coin piece, but we leave it up to you to come up with a fun icon.

Describe the solution you'd like A clear and concise description of what you
want to happen.

A fun icon representative of the Connect Four game. Dimensions must be 128px x 128px

Describe alternatives you've considered A clear and concise description of
any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature
request here.

@nickytonline nickytonline added the good first issue Good for newcomers label Oct 7, 2022
@LoganArnett
Copy link
Contributor

I can take a crack at this

@nickytonline
Copy link
Owner Author

Assigned it to you @LoganArnett!

@LoganArnett
Copy link
Contributor

2 quick options but can work on something more if needed

More dynamic like the game

favicon-connect-four-1

Simple and clean

favicon-connect-four-2

@LoganArnett
Copy link
Contributor

Will create a PR with the file once confirmed

@nickytonline
Copy link
Owner Author

nickytonline commented Oct 9, 2022

I love this one @LoganArnett!

favicon-connect-four-1

Thoughts @Narigo @sadiejay?

@nickytonline nickytonline added the design Anything related to visual design label Oct 9, 2022
@sadiejay
Copy link
Collaborator

sadiejay commented Oct 9, 2022

Agreed @nickytonline 🙌🏾

@Narigo
Copy link
Collaborator

Narigo commented Oct 9, 2022

I like the board style more as well. I'd love to have a board that could actually be played, though 😅

Maybe something like this? (If the 4 is still visible in the small scales...)
image

@nickytonline
Copy link
Owner Author

Actually one suggestion for my choice. Since there are only two game piece colours, could you make the yellow ones blue? Or maybe make them all blue and the current red ones could be yellow. Thoughts?

@LoganArnett
Copy link
Contributor

Yea when I did the full 6x7 board it wasnt very visible as an actual favicon. I used the color layout I did for visibility and aesthetic but I can go to a full board if you want. And what are the 2 colors? I tried to have blue represent an empty square and red and yellow being pieces.

@LoganArnett
Copy link
Contributor

@Narigo it is very difficult to see at 128x128 and true favicon display will be even smaller like:
image

@Narigo
Copy link
Collaborator

Narigo commented Oct 9, 2022

I'm okay with whatever you choose 👍
For the example, I used blue for empty spots as well. Red began and won in the example ;)

@nickytonline
Copy link
Owner Author

nickytonline commented Oct 9, 2022

@Narigo it is very difficult to see at 128x128 and true favicon display will be even smaller like:

image

Actually, it still looks good in @Narigo's example even at 128 x 128, and I just noticed the red makes a 4. Just wondering how we could make the 4 pop more. I think from the classic game, the board was blue, so wondering if it could be a blue background, white for empty slots and keep the rest as is?

I also want to be mindful of your time, so if this is too much, just let us know.

@Narigo
Copy link
Collaborator

Narigo commented Oct 9, 2022

Maybe with a bit different colors and less space between them, it could pop out more? I don't feel it that much though.

image

Here would be an SVG to change colors etc. I've put it into square format:
connect-4-board

@LoganArnett
Copy link
Contributor

favicon

@LoganArnett
Copy link
Contributor

I tried to update for the favicon with colors that would make the 4 pop a little more by fading the white and yellow slightly, keeping the darker blue, and adding minimal shadow to the red pieces

@nickytonline
Copy link
Owner Author

Love it @LoganArnett! Thanks so much for doing this. I'll just let @sadiejay and @Narigo chime in again. Looking forward to seeing the new icon rolled out. 😎

@LoganArnett LoganArnett mentioned this issue Oct 9, 2022
8 tasks
@LoganArnett
Copy link
Contributor

I created the PR but can update as needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Anything related to visual design good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants