Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Return array with node from getNeighborsAndSelf() when node is root #154

Merged
merged 2 commits into from
Jan 28, 2023

Conversation

localheinz
Copy link
Collaborator

@localheinz localheinz commented Jan 28, 2023

This pull request

  • asserts that getNeighborsAndSelf() returns an array with the node only when a node is the root of a tree
  • returns an array with the node only from getNeighborsAndSelf() when a node is the root of a tree

@localheinz localheinz added the bug label Jan 28, 2023
@localheinz localheinz self-assigned this Jan 28, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2023

Codecov Report

Merging #154 (9e7bdf6) into master (805b824) will not change coverage.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##              master      #154   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity        55        56    +1     
===========================================
  Files              6         6           
  Lines            150       154    +4     
===========================================
+ Hits             150       154    +4     
Impacted Files Coverage Δ
src/Node/NodeTrait.php 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@localheinz localheinz merged commit 5630648 into master Jan 28, 2023
@localheinz localheinz deleted the fix/neighbors-and-self branch January 29, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants