Fix PHPStan problems and be explicit #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szepeviktor
commented
Nov 27, 2020
src/Node/NodeTrait.php
Outdated
Comment on lines
217
to
223
| return \array_reduce( | ||
| $this->getChildren(), | ||
| static function ($size, $child) { | ||
| return $size + $child->getSize(); | ||
| }, | ||
| 1 | ||
| ); |
There was a problem hiding this comment.
This is bonus content 🎁
|
Please consider using @phpstan! |
|
Added |
|
Thank you for the information. I'm a PHPStan contributor. |
localheinz
force-pushed
the
static-analysis
branch
2 times, most recently
from
63c902b
to
cae1121
Compare
localheinz
force-pushed
the
static-analysis
branch
from
cae1121
to
e38c886
Compare
|
Thank you, @szepeviktor! |
|
You're welcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From https://twitter.com/localheinz/status/1332251797226991616