Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deliberation quick fixes4 #285

Merged
merged 5 commits into from Feb 14, 2022
Merged

Conversation

fcamblor
Copy link
Contributor

@fcamblor fcamblor commented Jan 25, 2022

Some quick fixes (again) :

  • Storing "Show my vote" and "Show GT Votes" choices on allVotes screen in localstorage, so that we keep its value across navigations

  • Improved a little bit the colors on allVotes screen, using a less aggressive yellow + removed greyed background on sorted columns

All_votes_-_Devoxx_France_2022

  • When no available slot remains, using the whole color space (from red to green) for average scores, instead of the red -> yellow color space (second part of the score scales introduced yesterday)

@aheritier
Copy link
Collaborator

Everything is working as expected @fcamblor cc @nicmarti
I am not able to test the floating new messages feature for now because I already read all my notifications
Doing some random tests I saw the "Nouveaux messages" on the private window of QWC-2883 but it's strange because my counter of notifications is empty. It's the only talk I found like this ...

I prefer the lighter yellow which is less agressive, but it might be great I think to use a different colors for HTML links to make the titles more readable for old eyes like me (but it's always better than with the current yellow). It's just a problem of contrast

@fcamblor
Copy link
Contributor Author

Doing some random tests I saw the "Nouveaux messages" on the private window of QWC-2883 but it's strange because my counter of notifications is empty. It's the only talk I found like this ...

Let's wait a little bit prior to merging the PR, I'll re-do some test this evening (not sure if I was at 💯 of my abilities at the time I made the tests this morning :-) )

@sonarcloud
Copy link

sonarcloud bot commented Feb 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@fcamblor
Copy link
Contributor Author

I removed the floating line from the PR, so that we're able to merge this PR without having to wait any longer :-)

@aheritier
Copy link
Collaborator

Good idea @fcamblor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants