New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable multiselectable not working #16

Closed
tonykim5 opened this Issue Feb 23, 2017 · 5 comments

Comments

Projects
None yet
2 participants
@tonykim5

tonykim5 commented Feb 23, 2017

Disabling the multiselectable feature doesn't seem to work. Pasted the HTML from my site's page source. I'm using v2.2.1.

<div class="js-accordion faq-accordian" data-accordion-multiselectable="none" data-accordion-prefix-classes="faq-accordian" role="tablist" aria-multiselectable="true">

@nico3333fr

This comment has been minimized.

Show comment
Hide comment
@nico3333fr

nico3333fr Feb 23, 2017

Owner

Hi @tonykim5

you are right, this was a bug, I've fixed it in the last commit : 4359a9c

Thanks a lot for reporting it ;)

Owner

nico3333fr commented Feb 23, 2017

Hi @tonykim5

you are right, this was a bug, I've fixed it in the last commit : 4359a9c

Thanks a lot for reporting it ;)

@nico3333fr nico3333fr added the bug label Feb 23, 2017

@nico3333fr nico3333fr self-assigned this Feb 23, 2017

@tonykim5

This comment has been minimized.

Show comment
Hide comment
@tonykim5

tonykim5 Feb 24, 2017

Hey Nicolas, thanks for the quick response but the updated version doesn't seem to be working still. I made sure the old version wasn't being cached in my browser.

tonykim5 commented Feb 24, 2017

Hey Nicolas, thanks for the quick response but the updated version doesn't seem to be working still. I made sure the old version wasn't being cached in my browser.

@nico3333fr

This comment has been minimized.

Show comment
Hide comment
@nico3333fr

nico3333fr Feb 27, 2017

Owner

Hi @tonykim5 this is strange, it works for me, see example here https://a11y.nicolas-hoffmann.net/accordion/?nomultiselect=1

Owner

nico3333fr commented Feb 27, 2017

Hi @tonykim5 this is strange, it works for me, see example here https://a11y.nicolas-hoffmann.net/accordion/?nomultiselect=1

@tonykim5

This comment has been minimized.

Show comment
Hide comment
@tonykim5

tonykim5 Mar 28, 2017

Yes I got it to work now. Thanks Nicolas! Great set of accessible plugins.

tonykim5 commented Mar 28, 2017

Yes I got it to work now. Thanks Nicolas! Great set of accessible plugins.

@nico3333fr

This comment has been minimized.

Show comment
Hide comment
@nico3333fr

nico3333fr Mar 29, 2017

Owner

Great, happy to hear it is ok ! 👍

Owner

nico3333fr commented Mar 29, 2017

Great, happy to hear it is ok ! 👍

@nico3333fr nico3333fr reopened this Mar 29, 2017

@nico3333fr nico3333fr closed this Mar 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment