Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow setting multiselectable via options #18

Closed
swissspidy opened this issue Mar 24, 2017 · 1 comment
Closed

Allow setting multiselectable via options #18

swissspidy opened this issue Mar 24, 2017 · 1 comment
Assignees
@nico3333fr
Labels
bug

Comments

@swissspidy
Copy link

If you pass multiselectable as an option like any other, its value gets overridden by specificOptions.multiselectable (the data-accordion-multiselectable) attribute.

I think it makes sense to not override it as long as no data attribute is present, e.g. when I use $( '$( '.foobar' ).accordion( { multiselectable: false } );, I expect multiselectable to be false.
@nico3333fr nico3333fr self-assigned this Mar 24, 2017
@nico3333fr nico3333fr added the bug label Mar 28, 2017
nico3333fr added a commit that referenced this issue Mar 28, 2017
@nico3333fr
Updated specific options
d93ff89 
If you passed multiselectable as an option like any other, its value was overridden by specificOptions.multiselectable (the data-accordion-multiselectable) attribute. 
It is fixed: if no data-accordion-multiselectable is specified, the value is taken from the options.

Closed #18
@nico3333fr
Copy link
Owner

You are right, it is fixed now.

Thanks for pointing this out 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nico3333fr nico3333fr

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@swissspidy @nico3333fr