Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generated numerical ID invalid selector #10

Closed
brandlewco opened this issue Oct 11, 2018 · 2 comments
Closed

Generated numerical ID invalid selector #10

brandlewco opened this issue Oct 11, 2018 · 2 comments
Assignees
@nico3333fr
Labels
bug

Comments

@brandlewco
Copy link

I run into a problem where any ID for an accordion that starts with a number, like id="6rjsaq98q2" breaks when used.

Uncaught DOMException: Failed to execute 'querySelector' on 'Document': '#6rjsaq98q2[data-hashaccordion-id="k0vuv1jup0"]' is not a valid selector.

No problem when generated ID starts with a letter.
@nico3333fr nico3333fr self-assigned this Oct 14, 2018
@nico3333fr nico3333fr added the bug label Oct 14, 2018
@nico3333fr
Copy link
Owner

Fine, you bring me a solution for #9 ! 👍

I'm committing a quick fix right now.

nico3333fr added a commit that referenced this issue Oct 14, 2018
@nico3333fr
Fix issue exception in selector
8a9b981 
Fixes #9 & #10 !
@nico3333fr nico3333fr mentioned this issue Oct 14, 2018
Closed
@nico3333fr
Copy link
Owner

Hi @lewcrewco

the last commit fixed this issue, thanks again for your help 8a9b981 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nico3333fr nico3333fr

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nico3333fr @brandlewco