Code refactor and small bugfixes #5
Conversation
…ed to python 3.10
- added more docstrings and comments - use more pathlib functions - replaced the pandas dependency with csv from the standard library - made edge storage part of class functionality - added constants to control header, timeout and user interaction - rewrote parts of the code to be more pythonic and robust - improved error handling
| #else: | ||
| # return [] | ||
| # TODO: Don't hard-code URLs | ||
| # TODO: What is the seenotrettung about? |
There was a problem hiding this comment.
at the time we created this project, there were some issues with etherpad servers. If a pad broke, one could still obtain the content via some "hack" (history mode or similar) and copy-paste it into a new one (seenotrettung called that time, term was created/evolved during a plenum) which would be the go-to pad then.
There was a problem hiding this comment.
That makes sense. Can I remove that part from the code then?
|
Looks really good (besides the mentioned points in your above comment), thanks a lot for the work here! I think regarding dependencies that should be fine for now, as you did not add any new depedneices which aren't in the standard library. Regarding license: good point, will think about adding one. |
|
I combined #3 and #4 to get the best of both worlds, and updated the code on top of that. The dependencies have changed, so I suspect the nix/poetry files need to be updated, but I have no idea how to do that. Maybe you could help @mmarx?
We could also add a license to the project to make the permitted type of use clearer, but I'm not sure which would be best.