Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Directories Selected Original Files Not Deleted -- Crashes and NSP files left when NSZ file is created #141

Closed
jsmith1299 opened this issue Oct 7, 2023 · 3 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@jsmith1299
Copy link

jsmith1299 commented Oct 7, 2023

Hello,

I am running the latest version 4.5 of NSZ GUI and have selected rm-source. When I am in a directory (eg c:\nsp\game1) this seems to work. If I select multiple directories in say c:\nsp, the original files in c:\nsp\game1, c:\nsp\game2 are not deleted.

Also not sure what is happening but most of the time if the application completes even though I have asked to delete the NSP it doesn't (while creating the nsz) or other times it crashes and terminates the command window. I re-run the process again first removing the NSP file and it works.

@jsmith1299 jsmith1299 changed the title Multiple Directories Original File Not Deleted Multiple Directories Selected Original Files Not Deleted Oct 7, 2023
@jsmith1299 jsmith1299 changed the title Multiple Directories Selected Original Files Not Deleted Multiple Directories Selected Original Files Not Deleted -- Crashes and NSP files left when NSZ file is created Oct 15, 2023
@jsmith1299
Copy link
Author

Here is more information. Whenever the deletes run I get this wraning,

[WARNING] Skipped deleting source file because target file doesn't exist
[WARNING] Skipped deleting source file because target file doesn't exist
[WARNING] Skipped deleting source file because target file doesn't exist

I am not sure what is happening as the source and target files are there after this finishes.

@nicoboss nicoboss self-assigned this Oct 16, 2023
@nicoboss nicoboss added the bug Something isn't working label Oct 16, 2023
@nicoboss nicoboss added this to the v4.6 milestone Oct 16, 2023
@jsmith1299
Copy link
Author

Thank you for confirming the issue! Much appreciated (and your work) and will wait for the correction.

@nicoboss
Copy link
Owner

@jsmith1299 Thanks a lot for reporting this issue.
A fix is now deployed in the latest NSZ 4.6.0 release.
Big thanks to the first-time contributor @siddhartha77 for fixing this issue in #163

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants