-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an additional source (https://www.workatastartup.com/) #66
Conversation
christosgousis
commented
Jun 9, 2024
- Added one more library requirement in ordet to run on windows (windows-curses)
- Added a button to scrape availiable job listings from workatastartup
- Create a python file for scraping the website and saving the job listings to the database
Hey @christosgousis and @GiorgosPapageorgiou ! Thank you so much for the PR. I'll be reviewing it in the next few days. This is super useful 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an excellent PR. It adds very useful functionality, it follows the structure of the original code, and it's straightforward to understand how it works
There are a few minor changes needed for this PR to be approved and merged:
- restore the
sample.env
file (so that it includes the textyour_openai_api_key_here
) - resolve the issue of being able to run
pip install -r config/requirements.txt
without errors, on a non-windows platform ##this is the most important thing to fix##
From a user experience perspective, it would be nice to have some sort of activity while waiting for the scraping to happen. Personally, I thought the process wasn't working. I was about to comment on the PR saying it didn't work, then it suddenly finished and showed it had found 67 listings 😄
I hope this fixes the above issues Also added updates when scraping Work at a startup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. It works. And it adds some excellent functionality to CommandJobs. Thank you
windows-curses; sys_platform == 'win32' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent. Simple and it works 😄
@@ -1,4 +1,4 @@ | |||
OPENAI_API_KEY= | |||
OPENAI_API_KEY=your_openai_api_key_here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you 🙏
Hey @christosgousis and @GiorgosPapageorgiou, I just realized one thing: it would be great if you could add an entry in the The code is already merged, so it's up to you if you want to do it. I think it would be awesome to not only have the code you guys contributed in the repo, but also have some of your words in the README as well If you are up for it, just create another PR with changes to the README. Thank you 🙏 |