Append Jaccard dissimilarity to dissim.py - Jaccard dissimilarity measure #36 #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is my first contribution so please help if I've not set up the review process correctly. This additional code should add the option to use Jaccard's dissimilarity in KModes
AGMortimer
changed the title
|
Nice, thanks for the contribution. Please add some unit tests for the new function, both testing the function itself and how it would be used in calling |
Updated to include testing for correct calculation of input arrays. Plus ensuring the input data is only binary and does not include
Altered to be specific about this being a solution only for binary input
|
Closing in favor of #129 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first contribution so please help if I've not set up the review process correctly.
This additional code should add the option to use Jaccard's dissimilarity in KModes