Upgrade Babel parser to 7.9.4 #118
Conversation
| @@ -227,6 +227,11 @@ | |||
| dependencies: | |||
| "@babel/types" "^7.8.3" | |||
|
|
|||
| "@babel/helper-validator-identifier@^7.10.4", "@babel/helper-validator-identifier@^7.9.0": | |||
| version "7.10.4" | |||
There was a problem hiding this comment.
Ahh I have no idea why we're getting 7.10 here. Yarn deduping is the worst.
There was a problem hiding this comment.
No idea! As long as tests are green and bug is fixed, that's legit to me.
|
I hoped that was a bug with the parser and that an upgrade would fix it. Thanks for doing that 👍 I can merge confidently since CI is all green 👌 |
|
@all-contributors add OliverJAsh for ideas,bug,code,doc (I'm sure it won't work, I'll fix this so it works again) |
|
I couldn't determine any contributions to add, did you specify any contributions? |
|
@all-contributors add OliverJAsh for ideas,bug,code,doc |
|
I couldn't determine any contributions to add, did you specify any contributions? |
|
@all-contributors please add OliverJAsh for ideas, bug, code and doc |
|
I've put up a pull request to add @OliverJAsh! 🎉 |
This seemed to fix the bug I mentioned over Twitter DMs, whereby
locwasnullfor the call expression inexport default a(1);.I chose 7.9.4 because: