Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Inline Variable on destructured object patterns #34

Merged
merged 29 commits into from Sep 18, 2019
Merged

Improve Inline Variable on destructured object patterns #34

merged 29 commits into from Sep 18, 2019

Conversation

nicoespeon
Copy link
Owner

@nicoespeon nicoespeon commented Sep 17, 2019 •
edited

Related to #25

inline-variable-destructured-object

Nicolas Carlo and others added 24 commits September 16, 2019 19:04
@nicoespeon
Handle basic Object Pattern
ef86423
@nicoespeon
Remove duplicated concept
cd7aa00
@nicoespeon
Handle renamed destructured variable
215235e
@nicoespeon
Handle assignments to things that are not objects
e72289c
@nicoespeon
Compute init name with different use cases
a0bd804
@nicoespeon
Merge guard clauses
864ad1f
@nicoespeon
Extract getInlinableCodeFromDeclaration()
9ea4fd7
@nicoespeon
Extract child creation from composite
7e8f9f2
@nicoespeon
Handle nested object pattern
49cbacf
@nicoespeon
Move isShadowIn() in AST
506a17d
@nicoespeon
Extract findInlinableCode()
0edb20c
@nicoespeon
Introduce base class CompositeInlinable
fc69cdf
@nicoespeon
Test InlinableObjectPattern updates
cb629de
@nicoespeon
Handle complex member expressions
77046e9
@nicoespeon
Extract destructured object pattern tests
7c1565c
@nicoespeon
Extract default selection
dede27f
@nicoespeon
Handle multi-line object pattern
7c66cf0
@nicoespeon
Handle object pattern in a multiple declaration
dd6392a
@nicoespeon
Pass selection to findInlinableCode()
4f8b21b
@nicoespeon
Check all object pattern properties
8500496
@nicoespeon
Introduce notion of SingleDeclaration()
578a051
@nicoespeon
Pass declarationSelection as a parameter
9653b07
@nicoespeon
Change implementation of declaration selection again
87f41f7
@nicoespeon
Handle cases with many other elements destructured
183e086
@nicoespeon nicoespeon force-pushed the fix/inline-variable-destructured branch from 91f3f64 to 183e086 Compare September 17, 2019 12:21
@noway noway mentioned this pull request Sep 17, 2019
Closed
2 tasks
@nicoespeon nicoespeon marked this pull request as ready for review September 18, 2019 12:08
@nicoespeon nicoespeon changed the title Improve Inline Variable on destructured objects (Object Pattern) Improve Inline Variable on destructured object patterns Sep 18, 2019
@nicoespeon nicoespeon merged commit 373edef into master Sep 18, 2019
@nicoespeon nicoespeon deleted the fix/inline-variable-destructured branch September 18, 2019 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@nicoespeon