migrate tslint to eslint #459

tjx666 · 2021-12-19T18:02:21Z

migrate tslint to eslint
fix eslint lint errors
replace pretty-quick with lint-staged
fix some ts compile error

But I occured an issue that I can't activate extenison. This issue is related with module code-block-writer which is dependent by ts-morph。

My version info:

Version: 1.64.0-insider (Universal)
Commit: d12df34e31b4a018735d312a8947d79331132368
Date: 2021-12-17T05:14:21.805Z
Electron: 13.5.2
Chromium: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Darwin x64 21.2.0

tjx666 · 2021-12-19T18:14:06Z

This project compile costs too long. One reason maybe whenever this ts project contains all test files. If I have free time, often weekend, I may help to do some more optimization to this project.

nicoespeon · 2022-01-06T13:51:14Z

Thanks for helping @tjx666. I will have a look at that too. I noticed that error recently, and I'm not sure where this is coming from. The file does exist, so that's weird.

cc @fabien0102

nicoespeon · 2022-01-06T13:53:09Z

src/playground/gilded-rose.ts

@@ -20,19 +20,19 @@ export class GildedRose {
  updateQuality() {
    for (let i = 0; i < this.items.length; i++) {
      if (
-        this.items[i].name != "Aged Brie" &&
-        this.items[i].name != "Backstage passes to a TAFKAL80ETC concert"
+        this.items[i].name !== "Aged Brie" &&


Oh, the playground is intentionally invalid. We should exclude this folder from the linter.

The playground code is the one that will open in the Extension Host when you debug locally.

nicoespeon · 2022-01-06T13:53:49Z

src/refactorings/extract-generic-type/extract-generic-type.ts

@@ -40,7 +40,7 @@ async function extractGenericType(editor: Editor) {

 function findAllOccurrences(ast: t.AST, selection: Selection): AllOccurrences {
  let selectedOccurrence: Occurrence | null = null;
-  let otherOccurrences: Occurrence[] = [];
+  const otherOccurrences: Occurrence[] = [];


👍 Nice, thanks for fixing all of these

nicoespeon · 2022-01-06T13:55:30Z

src/refactorings/split-multiple-declarations/split-multiple-declarations.ts

  onMatch: (path: t.NodePath<t.VariableDeclaration>) => void
 ): t.Visitor {
  return {
    VariableDeclaration(path) {
-      selection;


👍 Good catch.

nicoespeon · 2022-01-06T13:56:30Z

src/refactorings/rename-symbol/rename-symbol.ts

@@ -13,7 +13,7 @@ async function renameSymbol(editor: Editor) {
  }
 }

-function findSelectedSymbol(editor: Editor): Symbol {
+function findSelectedSymbol(editor: Editor): Nothing {


That doesn't seem right. result may be an Identifier. Both are implementing the Symbol interface, so the previous code should have been correct. What was the linter issue?

nicoespeon · 2022-01-06T13:58:20Z

src/type-checker/type-checker.ts

@@ -108,8 +108,7 @@ export class TypeChecker {
    program: ts.Program
  ): ts.Node | undefined {
    try {
-      // @ts-ignore Internal method
-      return ts.getTouchingPropertyName(
+      return (ts as any).getTouchingPropertyName(


Hmm I'd rather keep a @ts-expect-error here, explaining it's an internal method we are using. I don't like parsing stuff to as any because it bypasses type checking. @ts-expect-error leaves the door open for the problem to be solved in the future.

nicoespeon · 2022-01-06T14:00:08Z

.vscodeignore

@@ -10,7 +10,6 @@ src/**
 .adr-dir
 .gitignore
 **/tsconfig.json
-**/tslint.json
 **/*.map
 **/*.ts
 wallaby.js


We may need to revisit this list to make sure we don't bundle configuration files with the new setup.

nicoespeon · 2022-01-06T14:02:02Z

package.json

    "glob": "7.2.0",
    "husky": "7.0.4",
    "hygen": "6.1.0",
    "jest": "27.4.2",
+    "lint-staged": "^12.1.3",


🍰 I prefer to omit the caret and install exact versions of packages. That leaves no room for surprises. The JS world isn't very SemVer friendly, so I had surprises in the past with flexible versions being installed.

We have good tests and dependabot regularly makes sure we keep up-to-date, so that's not an issue.

nicoespeon · 2022-01-06T14:02:29Z

.eslintrc.js

+    "no-empty": OFF,
+    "no-use-before-define": OFF
+  }
+};


src/refactorings/inline/inline-variable/find-inlinable-code.ts

nicoespeon · 2022-01-06T14:05:58Z

@tjx666 can you fix the conflicts and address the few comments I left?

On my side, I'll investigate to fix the code-block-writer issue when activating the extension + try to make the project compile faster.

tjx666 · 2022-01-06T15:16:06Z

Fix them this weekend

nicoespeon · 2022-01-07T14:41:26Z

@tjx666 FYI, the "Cannot find module './comment-char.js'" was a bug caused by the upgrade of ts-morph to v13. I fixed that on the main branch (commit 43ed32f).

That doesn't optimize the perfs, but at least it works now 👍

tjx666 · 2022-01-08T18:10:59Z

@nicoespeon fixed

These are intentional. Such code is designed to be dirty, so you can refactor it with the extension when debugging.

nicoespeon · 2022-01-09T18:38:08Z

@tjx666 working like a charm! Thank you for this super cool upgrade ❤️

nicoespeon · 2022-01-09T18:38:59Z

@all-contributors please add tjx666 for infra

allcontributors · 2022-01-09T18:39:07Z

@nicoespeon

I've put up a pull request to add @tjx666! 🎉

长风 added 6 commits December 20, 2021 00:37

set registry to https://registry.yarnpkg.com

af7c7e6

remove tslint related configs

5899c42

integrate eslint

8f28984

fix eslint lint errors

65b5bbe

fix ts compile error

fc1493b

replace pretty-quick with lint-staged

ed6b6bd

nicoespeon reviewed Jan 6, 2022

View reviewed changes

.eslintrc.js

"no-empty": OFF,

"no-use-before-define": OFF

}

};

Copy link

Owner

nicoespeon Jan 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice!

nicoespeon reviewed Jan 6, 2022

View reviewed changes

src/refactorings/inline/inline-variable/find-inlinable-code.ts Show resolved Hide resolved

长风 added 3 commits January 9, 2022 01:09

Merge branch 'main' of github.com:nicoespeon/abracadabra

1243a10

build: ignore some folders to eslint

6393679

fix: wrong refactor

bcef7dc

nicoespeon mentioned this pull request Jan 9, 2022

ignore docs dir with gifs to reduce extension size #480

Merged

nicoespeon added 5 commits January 9, 2022 13:29

Revert changes on playground files

0c9fb45

These are intentional. Such code is designed to be dirty, so you can refactor it with the extension when debugging.

Use 2-spaces indentation

211c10b

Explain why we ignore this TS error

a1b0574

Update lockfile with fixed versions

f81cbb4

Re-use the existing interface

7e2fcdc

nicoespeon enabled auto-merge January 9, 2022 18:38

allcontributors bot mentioned this pull request Jan 9, 2022

docs: add tjx666 as a contributor for infra #483

Merged

nicoespeon merged commit 709e9c7 into nicoespeon:main Jan 9, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

migrate tslint to eslint #459

migrate tslint to eslint #459

tjx666 commented Dec 19, 2021

tjx666 commented Dec 19, 2021

nicoespeon commented Jan 6, 2022

nicoespeon Jan 6, 2022

nicoespeon Jan 6, 2022

nicoespeon Jan 6, 2022

nicoespeon Jan 6, 2022

nicoespeon Jan 6, 2022

nicoespeon Jan 6, 2022

nicoespeon Jan 6, 2022

nicoespeon Jan 6, 2022

nicoespeon commented Jan 6, 2022

tjx666 commented Jan 6, 2022

nicoespeon commented Jan 7, 2022

tjx666 commented Jan 8, 2022

nicoespeon commented Jan 9, 2022

nicoespeon commented Jan 9, 2022

allcontributors bot commented Jan 9, 2022

migrate tslint to eslint #459

migrate tslint to eslint #459

Conversation

tjx666 commented Dec 19, 2021

tjx666 commented Dec 19, 2021

nicoespeon commented Jan 6, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nicoespeon commented Jan 6, 2022

tjx666 commented Jan 6, 2022

nicoespeon commented Jan 7, 2022

tjx666 commented Jan 8, 2022

nicoespeon commented Jan 9, 2022

nicoespeon commented Jan 9, 2022

allcontributors bot commented Jan 9, 2022