This repository has been archived by the owner on Jul 13, 2024. It is now read-only.
Add the ability to put some text in the commit bubble. (commitDotText) #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabien0102
suggested changes
Jul 5, 2018
src/gitgraph.js
Outdated
| @@ -1053,6 +1053,7 @@ | |||
| * @param {number[]} [options.lineDash = this.template.commit.dot.lineDash] | |||
| * | |||
| * @param {string} [options.message = "He doesn't like George Michael! Boooo!"] - Commit message | |||
| * @param {string} [options.message] - short commit message (A few chars) to appear on the commit dot | |||
There was a problem hiding this comment.
Bad copy/past here, this should be [options.messageShort] 😉
src/gitgraph.js
Outdated
| @@ -1205,6 +1207,19 @@ | |||
| } | |||
| } | |||
|
|
|||
| if (this.messageShort !== undefined) { | |||
There was a problem hiding this comment.
You can write if (this.messageShort) here, to be consistant with the actual code style.
62 tasks
nicoespeon
reviewed
Jul 6, 2018
examples/index.js
Outdated
| @@ -77,6 +77,7 @@ var commitConfig = { | |||
| dotStrokeWidth: 10, | |||
| messageHashDisplay: false, | |||
| messageAuthorDisplay: true, | |||
| messageShort: "C1", | |||
There was a problem hiding this comment.
I don't think messageShort is explicit enough for people without context.
What do you think about something like commitDotText? Something else?
carlorivera
changed the title
|
Good for me too. Merging it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to put some text in the commit bubble.
I'm using this to generate some docs and find it useful for referring to commits.