Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selected lists mess up when you select another board #31

Closed
bastienEichenberger opened this issue Jun 7, 2016 · 3 comments
Closed

Selected lists mess up when you select another board #31

bastienEichenberger opened this issue Jun 7, 2016 · 3 comments
Assignees
Labels

Comments

@bastienEichenberger
Copy link

Hi,
I just saw a little bug.
When I change the active Board I have the same list on _Work begin_and Work end.
If I clich on Work end the data aren't loaded.
When I click on the button refresh data I don't obtain new datas.

capture d ecran 2016-06-07 a 09 15 39
capture d ecran 2016-06-07 a 09 15 46

@nicoespeon nicoespeon changed the title little bug Last list is not properly selected when changing selected board Jun 8, 2016
@nicoespeon nicoespeon added the bug label Jun 8, 2016
@nicoespeon nicoespeon self-assigned this Jun 8, 2016
@nicoespeon
Copy link
Owner

Thanks for pointing out @bastienEichenberger!

The fact that the last list isn't correctly selected when you change the selected board is a behavior I want to improve indeed. I edited your issue to deal with that little bug in UX.

Concerning the fact that data doesn't update after you select the appropriate list, I noticed this to be a regression from #30. I’ll find out why and solve this issue in this PR. I’ll let you know when I'm done =)

Thanks for catching those!

@nicoespeon
Copy link
Owner

Well I concluded wrong and it's not related at all to #28 / #30.

This is an actual bug: something is not getting properly updated when a new board is selected. It stays on locally stored values of selected lists, which may not match the new board ones, hence this behavior.

@nicoespeon nicoespeon changed the title Last list is not properly selected when changing selected board Selected lists mess up when you select another board Jul 6, 2016
@nicoespeon
Copy link
Owner

nicoespeon commented Jul 6, 2016

Use case

Change selected board.

  • Expected: first & last lists of the board are the limits
  • Actual:
    • if a list has the same name, it is selected (Acceptable)
    • otherwise, first list is selected, even for the "Work ends" select (Bug)
    • data display the last list only, excepted if a list name is matching (Bug)

It seems to mess up with localStorage values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants