Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shift horizontal scroll glitch #47

Closed
Mideks opened this issue Feb 28, 2024 · 3 comments
Closed

Shift horizontal scroll glitch #47

Mideks opened this issue Feb 28, 2024 · 3 comments

Comments

@Mideks
Copy link
Contributor

Mideks commented Feb 28, 2024

In 342f294 you add support for horizontal scrolling, even when Shift is pressed. It doesn't work properly because if your cursor is over the image, you shouldn't scroll anymore. Otherwise we have some strange behaviour:

20240228-0424-56.7030430.mp4

(here I just try to resize image, but page scrolls with resize)

@Mideks
Copy link
Contributor Author

Mideks commented Feb 28, 2024

To reproduce this bug, you can simply shrink your window to a small size
You also need to have some large content on the page, such as a large image.

@nicojeske
Copy link
Owner

I am currently that in my test obsidian vault (no theme, no plugins) and I am not able to reproduce this behaviour. If I paste a big image without a size in markdown obsidian just scales it so that it fits in the window. And if I set a size in markdown obsidian just cuts the image and does not let me scroll horizontally.

@Mideks
Copy link
Contributor Author

Mideks commented Feb 28, 2024

Hmmm, I will try to test it in the empty vault later. If I can reproduce it, I will tell you.

@Mideks Mideks mentioned this issue Feb 28, 2024
Mideks added a commit to Mideks/mousewheel-image-zoom that referenced this issue Mar 1, 2024
- Enable proportional scaling of all media attachments (images, videos, audio, PDFs), text blocks, and even Markdown files on the canvas using modifier key + mouse wheel, provided that these elements are not selected or focused for editing.
- Introduce the ability to undo node scaling via ctrl+z, as if you were undoing the scaling action performed with the mouse.

Note: Due to ongoing issue nicojeske#47, normal scaling is temporarily restricted to use with the Alt key.

Related to: nicojeske#37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants