Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zoom for excalidraw images (fix #28) #39

Merged
merged 1 commit into from Feb 26, 2024

Conversation

Mideks
Copy link
Contributor

@Mideks Mideks commented Feb 26, 2024

Fixed #28
Excalidraw images should now zoom correctly.

Excalidraw images should now zoom correctly.
Copy link
Owner

@nicojeske nicojeske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well that was a rather simple fix. Just tested it locally and everything seems to work as intended.

I will merge this and your other PR later today and then publish a new version.

Thank you very much!

@Mideks
Copy link
Contributor Author

Mideks commented Feb 26, 2024

I'm glad my hard work didn't go unnoticed, hah, thanks.
I think bug is happen in dcb2243 commit, because excalidraw images IS "app://...", but not "app://local..."

@Mideks
Copy link
Contributor Author

Mideks commented Feb 26, 2024

I also fixed another bug in there #41 . It's such a simple solution, but it's not easy.....

@Mideks Mideks changed the title Fix zoom for excalidraw images (#28) Fix zoom for excalidraw images (fix #28) Feb 26, 2024
@nicojeske nicojeske merged commit e5afc8c into nicojeske:master Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed in Excalidraw
2 participants