Fixed the google preview and the canonical link to respect the templa… #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te's slashurls setting
|
I believe this may be a bug in the Processwire API. Here is the referenced bug report processwire/processwire-issues#187 You were using $page->httpUrl and I changed that to $page->url(true). Anyways, the way I do it in my pull request should fix it without people having to wait for the bug to be fixed in Processwire. I assuming this is important to fix because currently MarkupSEO is outputting the wrong value for the canonical links on people's websites. |
|
This is now fixed in core, but I would recommend merging this pull request so that it fixes the previous versions of Processwire with MarkupSEO. |
|
You're right, thanks for the heads up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…te's slashurls setting as stated in #35
Also removed a trailing "." in the Google Preview's Description
Hope that helps