Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement issue #2: Support multiple repositories #23

Merged
merged 3 commits into from
Oct 5, 2019

Conversation

nicokosi
Copy link
Owner

@nicokosi nicokosi commented Oct 5, 2019

Implement issue #23

  • Parse repository separated by commas
  • Make parallel GitHub requests
  • Check that the executable built with GraalVM still works

@nicokosi nicokosi added enhancement New feature or request wip labels Oct 5, 2019
@nicokosi nicokosi changed the title Implement #2: Support multiple repositories Implement issue #2: Support multiple repositories Oct 5, 2019
@nicokosi nicokosi force-pushed the fix-#2-Support-multiple-repositories branch from 0607268 to d8121a3 Compare October 5, 2019 10:44
@nicokosi nicokosi added wip and removed wip labels Oct 5, 2019
@nicokosi
Copy link
Owner Author

nicokosi commented Oct 5, 2019

Kotlin coroutines are visibly still not compatible with GraalVM 19.2.0.1 😭:

Using java version 19.2.0.1-grl in this shell.
Copying 'libsunec' shared library (Sun Elliptic Curve crypto):
'libsunec' shared library has been copied! ✅
Build executable from JAR via GraalVM:
Downloading: Component catalog from www.graalvm.org
Processing component archive: Native Image
Downloading: Component native-image: Native Image  from github.com
Installing new component: Native Image (org.graalvm.native-image, version 19.2.0.1)
[pullpitoK:23139]    classlist:   2,250.81 ms
[pullpitoK:23139]        (cap):   5,271.10 ms
[pullpitoK:23139]        setup:   6,765.94 ms
[pullpitoK:23139]     analysis:   3,291.25 ms
Error: Non-reducible loop
Detailed message:
Call path from entry point to pullpitok.AppKt$displayEvents$2.invokeSuspend(Object):
	at pullpitok.AppKt$displayEvents$2.invokeSuspend(App.kt)
	at pullpitok.AppKt$displayEvents$2.invoke(App.kt)
	at kotlinx.coroutines.intrinsics.UndispatchedKt.startUndispatchedOrReturn(Undispatched.kt:91)
	at kotlinx.coroutines.CoroutineScopeKt.coroutineScope(CoroutineScope.kt:180)
	at pullpitok.AppKt.displayEvents(App.kt:43)
	at pullpitok.AppKt$main$2.invokeSuspend(App.kt:16)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
	at kotlin.coroutines.ContinuationKt.startCoroutine(Continuation.kt:114)
	at kotlin.coroutines.jvm.internal.RunSuspendKt.runSuspend(RunSuspend.kt:19)
	at pullpitok.AppKt.main(App.kt)
	at com.oracle.svm.core.JavaMainWrapper.runCore(JavaMainWrapper.java:151)
	at com.oracle.svm.core.JavaMainWrapper.run(JavaMainWrapper.java:186)
	at com.oracle.svm.core.code.IsolateEnterStub.JavaMainWrapper_run_5087f5482cc9a6abc971913ece43acb471d2631b(generated:0)

Cf. oracle/graal#366.

@nicokosi nicokosi added bug Something isn't working do-not-merge and removed bug Something isn't working wip labels Oct 5, 2019
@nicokosi nicokosi force-pushed the fix-#2-Support-multiple-repositories branch 2 times, most recently from 50b879f to 46510d1 Compare October 5, 2019 16:03
The first CLI parameter is now interpreted as a comma-separated list of
repositories.

Not implemented with a Kotlin coroutine channel since GraalVM is not compatible with coroutines yet.
See oracle/graal#366.
@nicokosi nicokosi force-pushed the fix-#2-Support-multiple-repositories branch from 46510d1 to 2701502 Compare October 5, 2019 16:14
@nicokosi nicokosi force-pushed the fix-#2-Support-multiple-repositories branch from 19004c0 to 771a2a3 Compare October 5, 2019 17:08
@nicokosi nicokosi merged commit 1f6e419 into master Oct 5, 2019
@nicokosi nicokosi deleted the fix-#2-Support-multiple-repositories branch October 5, 2019 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant